Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VoiceBroadcast: Display the playback duration in the default state #7110

Merged
merged 15 commits into from
Nov 28, 2022
Merged

VoiceBroadcast: Display the playback duration in the default state #7110

merged 15 commits into from
Nov 28, 2022

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Nov 25, 2022

Display the playback duration in the default state

@phloux phloux requested a review from giomfo November 25, 2022 13:36
@phloux phloux changed the title Display the playback duration in the default state VoiceBroadcast - Display the playback duration in the default state Nov 25, 2022
@phloux phloux changed the title VoiceBroadcast - Display the playback duration in the default state VoiceBroadcast: Display the playback duration in the default state Nov 25, 2022
@yostyle yostyle force-pushed the yostyle/voicebroadcast_live_playback branch from 39e6b87 to e9c26e1 Compare November 25, 2022 15:38
Base automatically changed from yostyle/voicebroadcast_live_playback to develop November 25, 2022 19:59
@phloux phloux marked this pull request as ready for review November 28, 2022 08:21
@codecov
Copy link

codecov bot commented Nov 28, 2022 •
edited
Loading

Codecov Report

Base: 11.73% // Head: 11.73% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (24f5fec) compared to base (17b45aa).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #7110   +/-   ##
========================================
  Coverage    11.73%   11.73%           
========================================
  Files         1620     1620           
  Lines       159271   159262    -9     
  Branches     64804    64803    -1     
========================================
+ Hits         18687    18689    +2     
+ Misses      139940   139937    -3     
+ Partials       644      636    -8
Flag Coverage Δ
uitests 54.83% <ø> (+0.03%) ⬆️
unittests 5.94% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/VoiceBroadcastSDK/VoiceBroadcastAggregator.swift 0.00% <0.00%> (ø)
...ck/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift 0.00% <0.00%> (ø)
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+4.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

giomfo
giomfo approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

giomfo
giomfo reviewed Nov 28, 2022
View reviewed changes
RiotSwiftUI/Modules/Room/VoiceBroadcastPlayback/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift Outdated
@@ -333,6 +341,9 @@ extension VoiceBroadcastPlaybackViewModel: VoiceBroadcastAggregatorDelegate {
}

func voiceBroadcastAggregatorDidEndLoading(_ aggregator: VoiceBroadcastAggregator) {
if state.playbackState == .buffering {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phlniji please remove this block, the process will be launched on voiceBroadcastAggregatorDidUpdateData

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in last commit.

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

yostyle
yostyle approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phloux phloux merged commit 05af299 into develop Nov 28, 2022
@phloux phloux deleted the phlpro/voicebroadcast-display-playback-duration branch November 28, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giomfo giomfo giomfo approved these changes

@yostyle yostyle yostyle approved these changes

Assignees

@yostyle yostyle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phloux @yostyle @giomfo