Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Text Editor: Design Improvements #7127

Merged
merged 13 commits into from
Nov 30, 2022

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 29, 2022

  • When minimised, and there is one single line, the toggle button should be more centred
  • Less size for the bottom sheet custom height, have the bottom distance match the design
  • Set the scrollsEnabled value to not be scrollable on iOS 16 in the ComposerActionsList:
  • Change asset for the disabled plain text mode to match the on the Figma
  • Move a bit upwards the + and the send button when plain text mode is enabled, so that they can be centred with the rounded rectangle (they’re just slightly below right now)
  • All of the text formatting row in the bottom sheet should be tappable to change the text formatting toggle
  • iOS 15 fullscreen mode not working
  • Toggle looks like android, should look like iOS
  • iPhone 14 better spacing in fullscreen + reply/edit mode
  • Fix for 7130 issue

@Velin92 Velin92 marked this pull request as draft November 29, 2022 17:54
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 11.73% // Head: 11.77% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (1c28ba3) compared to base (9f337de).
Patch coverage: 54.08% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7127      +/-   ##
===========================================
+ Coverage    11.73%   11.77%   +0.04%     
===========================================
  Files         1620     1620              
  Lines       159282   159354      +72     
  Branches     64807    64853      +46     
===========================================
+ Hits         18689    18762      +73     
+ Misses      139957   139953       -4     
- Partials       636      639       +3     
Flag Coverage Δ
unittests 5.98% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.swift 0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
...rdinator/ComposerCreateActionListCoordinator.swift 0.00% <0.00%> (ø)
...ionList/Model/ComposerCreateActionListModels.swift 100.00% <ø> (ø)
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 85.41% <71.42%> (-0.68%) ⬇️
...eateActionList/View/ComposerCreateActionList.swift 81.18% <79.66%> (-6.17%) ⬇️
...List/MockComposerCreateActionListScreenState.swift 100.00% <100.00%> (ø)
...Modules/Home/AllChats/AllChatsViewController.swift 29.11% <0.00%> (+0.18%) ⬆️
...iot/Modules/Common/Views/BadgedBarButtonItem.swift 68.91% <0.00%> (+68.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Velin92 Velin92 marked this pull request as ready for review November 30, 2022 10:38
@Velin92 Velin92 linked an issue Nov 30, 2022 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Velin92 Velin92 merged commit aa43d74 into develop Nov 30, 2022
@Velin92 Velin92 deleted the mauroromito/design_improvements_2 branch November 30, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants