Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt the user before ending a voice broadcast #7132

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Dec 1, 2022

Prompt the user before ending a voice broadcast

@phloux phloux requested review from giomfo and yostyle December 1, 2022 15:40
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phloux phloux marked this pull request as ready for review December 1, 2022 16:10
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 11.77% // Head: 11.76% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (151a256) compared to base (1ee120c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7132      +/-   ##
===========================================
- Coverage    11.77%   11.76%   -0.01%     
===========================================
  Files         1620     1620              
  Lines       159379   159388       +9     
  Branches     64871    64884      +13     
===========================================
- Hits         18762    18759       -3     
- Misses      139969   139978       +9     
- Partials       648      651       +3     
Flag Coverage Δ
unittests 5.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oordinator/VoiceBroadcastRecorderCoordinator.swift 0.00% <ø> (ø)
...castRecorder/View/VoiceBroadcastRecorderView.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phloux phloux merged commit f2ab29b into develop Dec 2, 2022
@phloux phloux deleted the phlpro/voicebroadcast_stop_alert branch December 2, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants