Update unverifiable sessions copies (PSG-1002) #7138
Conversation
alfogrillo
requested review from
a team and
pixlwave
and removed request for
a team
Codecov ReportBase: 11.75% // Head: 11.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7138 +/- ##
========================================
Coverage 11.75% 11.76%
========================================
Files 1621 1621
Lines 159464 159469 +5
Branches 64929 64935 +6
========================================
+ Hits 18752 18755 +3
- Misses 140062 140064 +2
Partials 650 650
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -86,7 +86,7 @@ struct UserSessionCardViewData { | |||
| case .unverified: | |||
| return isCurrentSessionDisplayMode ? VectorL10n.userSessionUnverifiedAdditionalInfo : VectorL10n.userOtherSessionUnverifiedAdditionalInfo + " %@" | |||
| case .permanentlyUnverified: | |||
| return VectorL10n.userOtherSessionPermanentlyUnverifiedAdditionalInfo | |||
| return isCurrentSessionDisplayMode ? VectorL10n.userOtherSessionPermanentlyUnverifiedAdditionalInfo : VectorL10n.userOtherSessionPermanentlyUnverifiedAdditionalInfo + " %@" | |||
There was a problem hiding this comment.
I can see this is following the example above and we don't support RTL in EI so it isn't an issue, but really the placeholder should be part of the string itself so that translators could place it wherever makes most sense for their language.
There was a problem hiding this comment.
Yeah, it makes sense!
This time we didn't to this way to avoid to double the localized strings I guess (we use the same copy with the placeholder and without it in some cases).
|
Kudos, SonarCloud Quality Gate passed!
|
This PR updates the copies for unverifiable sessions showing also an informational bottom sheet for them.