Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message id for to-device events #7141

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Add message id for to-device events #7141

merged 1 commit into from
Dec 8, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Dec 7, 2022

See related SDK change

@Anderas Anderas requested review from a team and phloux and removed request for a team December 7, 2022 14:34
@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 11.75% // Head: 11.75% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4bb2e46) compared to base (d1c3ee1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7141      +/-   ##
===========================================
- Coverage    11.75%   11.75%   -0.01%     
===========================================
  Files         1621     1621              
  Lines       159429   159429              
  Branches     64921    64921              
===========================================
- Hits         18735    18734       -1     
  Misses      140056   140056              
- Partials       638      639       +1     
Flag Coverage Δ
uitests 54.67% <ø> (+<0.01%) ⬆️
unittests 5.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/Managers/UISIAutoReporter/UISIAutoReporter.swift 20.62% <0.00%> (-0.13%) ⬇️
...Sessions/Common/View/UserSessionCardViewData.swift 87.17% <0.00%> (-1.29%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...ions/Coordinator/UserSessionsFlowCoordinator.swift 0.00% <0.00%> (ø)
RiotSwiftUI/Modules/Common/Mock/ScreenList.swift 90.19% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Anderas Anderas merged commit 5edb9b0 into develop Dec 8, 2022
@Anderas Anderas deleted the andy/todevice-id branch December 8, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants