Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the room description in the rooms list in case of live broadcast (incoming or outgoing) #7160

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Dec 12, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 11.72% // Head: 11.83% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (042c094) compared to base (4038e2b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7160      +/-   ##
===========================================
+ Coverage    11.72%   11.83%   +0.10%     
===========================================
  Files         1627     1627              
  Lines       159880   159953      +73     
  Branches     65162    65191      +29     
===========================================
+ Hits         18753    18927     +174     
+ Misses      140483   140388      -95     
+ Partials       644      638       -6     
Flag Coverage Δ
uitests 54.86% <ø> (+0.19%) ⬆️
unittests 5.97% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Modules/Common/Recents/Views/RecentTableViewCell.m 0.00% <0.00%> (ø)
...t/VoiceBroadcastSDK/MatrixSDK/VoiceBroadcastInfo.m 0.00% <ø> (ø)
...iceBroadcastSDK/MatrixSDK/VoiceBroadcastInfo.swift 0.00% <ø> (ø)
Riot/Utils/EventFormatter.m 8.66% <0.00%> (-1.30%) ⬇️
RiotSwiftUI/Modules/Common/Mock/ScreenList.swift 84.31% <0.00%> (-5.89%) ⬇️
Riot/Modules/MatrixKit/Models/Account/MXKAccount.m 11.04% <0.00%> (-0.11%) ⬇️
...tSwiftUI/Modules/Room/Composer/View/Composer.swift 80.39% <0.00%> (ø)
...eMessages/VoiceMessageAttachmentCacheManager.swift 0.00% <0.00%> (ø)
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@giomfo
Copy link
Member

giomfo commented Dec 13, 2022

@yostyle can you please add marge between the icon and the string Live Broadcast
image

@giomfo
Copy link
Member

giomfo commented Dec 13, 2022

There is a missing point:

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just add 2 comments

@yostyle yostyle force-pushed the yostyle/voicebroadcast_last_message branch from 4f13b48 to 042c094 Compare December 15, 2022 12:57
@yostyle yostyle closed this Dec 15, 2022
@giomfo giomfo reopened this Dec 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yostyle yostyle merged commit 3e9b3aa into develop Dec 19, 2022
@yostyle yostyle deleted the yostyle/voicebroadcast_last_message branch December 19, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants