Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old account data (PSG-635) #7164

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

alfogrillo
Copy link
Contributor

Description

This PR removes from the user's account_data device information that are outdated.
For more context see this MSC.

@alfogrillo alfogrillo requested review from a team and gileluard and removed request for a team December 13, 2022 14:47
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 11.75% // Head: 11.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c4219ad) compared to base (7170daa).
Patch coverage: 41.93% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7164   +/-   ##
========================================
  Coverage    11.75%   11.75%           
========================================
  Files         1621     1621           
  Lines       159477   159504   +27     
  Branches     64950    64964   +14     
========================================
+ Hits         18743    18753   +10     
- Misses      140095   140112   +17     
  Partials       639      639           
Flag Coverage Δ
uitests 54.67% <ø> (ø)
unittests 5.99% <41.93%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...w/Service/MatrixSDK/UserSessionsDataProvider.swift 40.29% <41.93%> (+2.46%) ⬆️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo merged commit 4038e2b into develop Dec 14, 2022
@alfogrillo alfogrillo deleted the alfogrillo/delete_old_account_data branch December 14, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants