Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Broadcast: Update recorder cell layout #7175

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Dec 15, 2022

Update Voice Broadcast recorder cell by adjusting some padding values

@phloux phloux marked this pull request as ready for review December 15, 2022 16:04
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phloux phloux changed the title Voice Broadcast: Update recorder cell by adjusting some padding values Voice Broadcast: Update recorder cell layout Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 11.83% // Head: 11.83% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fd747a2) compared to base (f61d29f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7175   +/-   ##
========================================
  Coverage    11.83%   11.83%           
========================================
  Files         1628     1628           
  Lines       159949   159949           
  Branches     65187    65187           
========================================
+ Hits         18927    18930    +3     
  Misses      140381   140381           
+ Partials       641      638    -3     
Flag Coverage Δ
uitests 54.76% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...castRecorder/View/VoiceBroadcastRecorderView.swift 0.00% <0.00%> (ø)
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...ingViewer/LiveLocationSharingViewerViewModel.swift 54.38% <0.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phloux phloux merged commit e388d70 into develop Dec 16, 2022
@phloux phloux deleted the phlpro/voice_broadcast_recorder_cell_paddings branch December 16, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants