Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle decryption errors in polls (PSG-1023) #7206

Merged
merged 6 commits into from
Jan 9, 2023

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Dec 23, 2022

Description

This PR adds the logic for showing decryption errors in polls.

Dependency

matrix-org/matrix-ios-sdk#1673

Result in the timeline

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 11.81% // Head: 11.83% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (6df8c7d) compared to base (80d3f57).
Patch coverage: 30.43% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7206      +/-   ##
===========================================
+ Coverage    11.81%   11.83%   +0.02%     
===========================================
  Files         1628     1630       +2     
  Lines       160158   160215      +57     
  Branches     65387    65419      +32     
===========================================
+ Hits         18924    18966      +42     
- Misses      140590   140611      +21     
+ Partials       644      638       -6     
Flag Coverage Δ
unittests 5.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Categories/Sequence.swift 0.00% <0.00%> (ø)
...linePoll/Coordinator/TimelinePollCoordinator.swift 0.00% <0.00%> (ø)
...linePoll/View/TimelinePollAnswerOptionButton.swift 54.16% <0.00%> (-0.46%) ⬇️
...ules/Room/TimelinePoll/View/TimelinePollView.swift 71.64% <60.00%> (-0.94%) ⬇️
...Modules/Room/TimelinePoll/TimelinePollModels.swift 93.75% <100.00%> (+0.20%) ⬆️
...es/Room/TimelinePoll/TimelinePollScreenState.swift 100.00% <100.00%> (ø)
...heet/SpaceSelector/View/SpaceSelectorListRow.swift 70.73% <0.00%> (-3.63%) ⬇️
...Recents/Service/MatrixSDK/RecentsListService.swift 12.70% <0.00%> (-0.40%) ⬇️
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.swift 0.00% <0.00%> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo changed the title Handle decryption errors in polls (PSG-1024) Handle decryption errors in polls (PSG-1023) Dec 30, 2022
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alfogrillo alfogrillo merged commit 7537ecd into develop Jan 9, 2023
@alfogrillo alfogrillo deleted the alfogrillo/poll_decryption_message branch January 9, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants