Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Element Alpha workflow #7256

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fix Element Alpha workflow #7256

merged 1 commit into from
Jan 11, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jan 10, 2023

set-output is deprecated and the generated warning fails the secret check.
This change matches the workflow used on ElementX which compares the PR's repo to make sure it matches the workflow's repo.

@pixlwave pixlwave added the Trigger-PR-Build Label to trigger builds for PRs label Jan 10, 2023
set-output is deprecated and the warning fails the secret check. Instead match ElementX by comparing the pull request repo to make sure it matches the workflow's repo.
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 11.83% // Head: 11.82% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (7843adb) compared to base (fb046b2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7256      +/-   ##
===========================================
- Coverage    11.83%   11.82%   -0.01%     
===========================================
  Files         1630     1630              
  Lines       160349   160373      +24     
  Branches     65502    65513      +11     
===========================================
  Hits         18970    18970              
- Misses      140740   140764      +24     
  Partials       639      639              
Flag Coverage Δ
unittests 5.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...r/Coordinator/VoiceBroadcastRecorderProvider.swift 0.00% <0.00%> (ø)
...oordinator/VoiceBroadcastRecorderCoordinator.swift 0.00% <0.00%> (ø)
...vice/MatrixSDK/VoiceBroadcastRecorderService.swift 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/BCrqLd

@pixlwave pixlwave requested review from a team and phloux and removed request for a team January 10, 2023 17:26
Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave pixlwave merged commit d798500 into develop Jan 11, 2023
@pixlwave pixlwave deleted the doug/fix-alpha branch January 11, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger-PR-Build Label to trigger builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants