Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved detection of voice broadcast completion during playback #7273

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Jan 16, 2023

For a voice broadcast, the paused/stopped state event contains a last_chunk_sequence indicating what the last chunk sequence number is.
During playback, we should use this last_chunk_sequence to detect whether we should stop playback or enter buffering state.

@nimau nimau force-pushed the nimau/PSF-1732_last_chunk_sequence branch from 4807168 to ee51fc7 Compare January 16, 2023 13:38
@nimau nimau added A-Voice-Broadcast T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Jan 16, 2023
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one comment

Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonarcloud
Copy link

sonarcloud bot commented Jan 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 11.84% // Head: 11.93% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (ee51fc7) compared to base (f8717de).
Patch coverage: 63.10% of modified lines in pull request are covered.

❗ Current head ee51fc7 differs from pull request most recent head f8a851b. Consider uploading reports for the commit f8a851b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7273      +/-   ##
===========================================
+ Coverage    11.84%   11.93%   +0.08%     
===========================================
  Files         1628     1633       +5     
  Lines       160358   160587     +229     
  Branches     65540    65640     +100     
===========================================
+ Hits         19001    19160     +159     
- Misses      140718   140788      +70     
  Partials       639      639              
Flag Coverage Δ
uitests 55.21% <85.11%> (+0.32%) ⬆️
unittests 5.96% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Config/BuildSettings.swift 43.07% <ø> (ø)
...ot/Modules/Room/RoomInfo/RoomInfoCoordinator.swift 0.00% <0.00%> (ø)
...RoomInfo/RoomInfoList/RoomInfoListViewAction.swift 0.00% <ø> (ø)
...Info/RoomInfoList/RoomInfoListViewController.swift 0.00% <0.00%> (ø)
...t/VoiceBroadcastSDK/VoiceBroadcastAggregator.swift 0.00% <0.00%> (ø)
...llHistory/Coordinator/PollHistoryCoordinator.swift 0.00% <0.00%> (ø)
...History/Service/MatrixSDK/PollHistoryService.swift 0.00% <0.00%> (ø)
...ck/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift 0.00% <0.00%> (ø)
...odules/Room/PollHistory/View/SegmentedPicker.swift 51.16% <51.16%> (ø)
...UI/Modules/Room/PollHistory/View/PollHistory.swift 90.90% <90.90%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@nimau nimau merged commit a775053 into develop Jan 16, 2023
@nimau nimau deleted the nimau/PSF-1732_last_chunk_sequence branch January 16, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Voice-Broadcast T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants