-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved detection of voice broadcast completion during playback #7273
Conversation
4807168
to
ee51fc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one comment
Riot/Modules/VoiceBroadcast/VoiceBroadcastSDK/VoiceBroadcastAggregator.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm agree with that https://github.com/vector-im/element-ios/pull/7273/files#r1071324381
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportBase: 11.84% // Head: 11.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7273 +/- ##
===========================================
+ Coverage 11.84% 11.93% +0.08%
===========================================
Files 1628 1633 +5
Lines 160358 160587 +229
Branches 65540 65640 +100
===========================================
+ Hits 19001 19160 +159
- Misses 140718 140788 +70
Partials 639 639
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
For a voice broadcast, the paused/stopped state event contains a last_chunk_sequence indicating what the last chunk sequence number is.
During playback, we should use this last_chunk_sequence to detect whether we should stop playback or enter buffering state.