Remove "Leave" button on Room details screen #7275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 11.93% // Head: 11.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7275 +/- ##
========================================
Coverage 11.93% 11.93%
========================================
Files 1633 1633
Lines 160556 160496 -60
Branches 65627 65608 -19
========================================
Hits 19160 19160
+ Misses 140757 140697 -60
Partials 639 639
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
NicolasBuquet
approved these changes
Jan 17, 2023
phloux
requested review from
a team and
Anderas
and removed request for
a team
Anderas
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in this issue, after the redesign of the room settings screen, there is now 2 "Leave" buttons on these screens : 1 at the first level, and 1 on the "Settings" one.
So, the goal of this PR is to remove the old one on "Settings".
1st level screen :
Settings screen before / After :
-> 