Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a deadlock when updating the summary of a room that has a voice broadcast #7300

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Jan 25, 2023

This PR is a hotfix fixing a deadlock happening when we try to update the summary of a room that has a voice broadcast.

To reproduce this issue in the current 1.9.16, simply clear the cache and a deadlock should occur if there is a voice broadcast in a room.

@nimau nimau added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Voice-Broadcast labels Jan 25, 2023
@nimau nimau marked this pull request as ready for review January 25, 2023 13:31
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good on my side, and everything is set up correctly for us to build a hotfix from.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (hotfix/1.9.16@ae87624). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##             hotfix/1.9.16    #7300   +/-   ##
================================================
  Coverage                 ?   11.97%           
================================================
  Files                    ?     1634           
  Lines                    ?   161034           
  Branches                 ?    65131           
================================================
  Hits                     ?    19291           
  Misses                   ?   141101           
  Partials                 ?      642           
Flag Coverage Δ
uitests 55.34% <0.00%> (?)
unittests 5.95% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tests are all ok

@nimau nimau merged commit f3b4c09 into hotfix/1.9.16 Jan 25, 2023
@nimau nimau deleted the nimau/hotfix_deadlock_update_room_summary branch January 25, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Voice-Broadcast T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants