Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Crypto SDK store key #7310

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Generate Crypto SDK store key #7310

merged 1 commit into from
Jan 30, 2023

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Jan 27, 2023

Use the existing EncryptionKeyManager to generate new Crypto SDK store key used to encrypt the sqlite store.

Additionally change some of the copy for the Labs option to enable crypto v2

@Anderas Anderas requested review from a team, gileluard and phloux and removed request for a team and gileluard January 27, 2023 10:20
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 11.98% // Head: 12.02% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (4a2a057) compared to base (87d8aec).
Patch coverage: 5.88% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7310      +/-   ##
===========================================
+ Coverage    11.98%   12.02%   +0.04%     
===========================================
  Files         1632     1629       -3     
  Lines       161312   161185     -127     
  Branches     66084    66037      -47     
===========================================
+ Hits         19329    19387      +58     
+ Misses      141339   141154     -185     
  Partials       644      644              
Flag Coverage Δ
uitests 55.70% <ø> (+0.39%) ⬆️
unittests 5.95% <5.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ot/Categories/MatrixSDKCrypto+LocalizedError.swift 0.00% <0.00%> (ø)
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)
...rs/EncryptionKeyManager/EncryptionKeyManager.swift 32.71% <9.09%> (-2.71%) ⬇️
...ules/Common/Avatar/ViewModel/AvatarViewModel.swift 90.00% <0.00%> (-2.86%) ⬇️
Riot/Modules/Analytics/DecryptionFailure.swift 0.00% <0.00%> (ø)
...alytics/Helpers/MXCallHangupReason+Analytics.swift 0.00% <0.00%> (ø)
...m/AllChatsOnboarding/View/AllChatsOnboarding.swift
...lChatsOnboarding/AllChatsOnboardingViewModel.swift
.../AllChatsOnboarding/AllChatsOnboardingModels.swift
...lChatsOnboarding/View/AllChatsOnboardingPage.swift
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anderas Anderas merged commit b741d35 into develop Jan 30, 2023
@Anderas Anderas deleted the andy/crypto_password branch January 30, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants