Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display backup import progress #7319

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Display backup import progress #7319

merged 1 commit into from
Jan 30, 2023

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Jan 30, 2023

Display import progress when manually restoring backup from settings. This is the quickest solution to make the screen usable for legacy element.

Settings
Simulator Screen Shot - iPhone 14 Pro Max - 2023-01-30 at 15 44 55

@Anderas Anderas requested review from a team and stefanceriu and removed request for a team January 30, 2023 15:49
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 12.02% // Head: 12.03% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c54546d) compared to base (4a2a057).
Patch coverage: 49.25% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7319   +/-   ##
========================================
  Coverage    12.02%   12.03%           
========================================
  Files         1629     1628    -1     
  Lines       161185   161172   -13     
  Branches     66037    66031    -6     
========================================
+ Hits         19387    19389    +2     
+ Misses      141154   141140   -14     
+ Partials       644      643    -1     
Flag Coverage Δ
uitests 55.70% <73.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Analytics/DecryptionFailure.swift 0.00% <ø> (ø)
Riot/Modules/Analytics/DecryptionFailureTracker.m 35.22% <ø> (ø)
...alytics/Helpers/MXCallHangupReason+Analytics.swift 0.00% <0.00%> (ø)
...KeyBackupRecoverFromPrivateKeyViewController.swift 0.00% <0.00%> (ø)
...eKey/KeyBackupRecoverFromPrivateKeyViewModel.swift 0.00% <0.00%> (ø)
Riot/Utils/EventFormatter.m 8.05% <0.00%> (ø)
.../Modules/Common/Avatar/View/SpaceAvatarImage.swift 39.72% <54.54%> (ø)
...ules/Common/Avatar/ViewModel/AvatarViewModel.swift 90.00% <90.90%> (ø)
...iftUI/Modules/Common/Avatar/View/AvatarImage.swift 71.42% <91.66%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌

@Anderas Anderas merged commit e8bc82f into develop Jan 30, 2023
@Anderas Anderas deleted the andy/import_progress branch January 30, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants