Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Crypto SDK for production #7333

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Enable Crypto SDK for production #7333

merged 1 commit into from
Feb 2, 2023

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Feb 2, 2023

Remove all DEBUG compiler flags to enable CryptoSDK for production. Additionally ensure that enableStartupProgress is enabled only when cryptoSDK is enabled (at least for now)

Corresponding SDK change

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀🚀

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 12.03% // Head: 12.03% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a9f8feb) compared to base (f339757).
Patch coverage: 11.11% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7333      +/-   ##
===========================================
- Coverage    12.03%   12.03%   -0.01%     
===========================================
  Files         1635     1635              
  Lines       161741   161735       -6     
  Branches     66386    66387       +1     
===========================================
- Hits         19463    19460       -3     
+ Misses      141634   141630       -4     
- Partials       644      645       +1     
Flag Coverage Δ
uitests 55.38% <ø> (ø)
unittests 5.91% <11.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Config/CryptoSDKConfiguration.swift 0.00% <0.00%> (ø)
...ot/Categories/MatrixSDKCrypto+LocalizedError.swift 0.00% <ø> (ø)
Riot/Managers/Settings/RiotSettings.swift 88.42% <ø> (ø)
Riot/Modules/Application/LegacyAppDelegate.m 14.55% <ø> (+<0.01%) ⬆️
...Modules/Home/AllChats/AllChatsViewController.swift 29.35% <0.00%> (-0.07%) ⬇️
Riot/Modules/Settings/SettingsViewController.m 0.00% <ø> (ø)
Config/CommonConfiguration.swift 86.80% <100.00%> (+0.59%) ⬆️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Anderas Anderas merged commit feb4736 into develop Feb 2, 2023
@Anderas Anderas deleted the andy/crypto_sdk branch February 2, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants