Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SegmentedPicker UI #7341

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Conversation

alfogrillo
Copy link
Contributor

Description

This PR slightly changes the UI of the SegmentedPicker component currently being used just in the poll history.

Before After
bef aft

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 12.09% // Head: 12.08% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (95eeb05) compared to base (3972da8).
Patch coverage: 5.55% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7341      +/-   ##
===========================================
- Coverage    12.09%   12.08%   -0.01%     
===========================================
  Files         1637     1637              
  Lines       161830   161844      +14     
  Branches     66429    66436       +7     
===========================================
- Hits         19566    19563       -3     
- Misses      141618   141635      +17     
  Partials       646      646              
Flag Coverage Δ
unittests 5.97% <3.03%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Config/CryptoSDKConfiguration.swift 0.00% <0.00%> (ø)
...ot/Categories/MatrixSDKCrypto+LocalizedError.swift 0.00% <ø> (ø)
Riot/Managers/Settings/RiotSettings.swift 88.42% <ø> (ø)
Riot/Modules/Analytics/Analytics.swift 9.41% <0.00%> (ø)
Riot/Modules/Application/LegacyAppDelegate.m 14.55% <ø> (ø)
...Modules/Home/AllChats/AllChatsViewController.swift 29.35% <0.00%> (ø)
Riot/Modules/Settings/SettingsViewController.m 0.00% <0.00%> (ø)
...odules/Room/PollHistory/View/SegmentedPicker.swift 36.66% <5.88%> (-14.50%) ⬇️
Config/CommonConfiguration.swift 86.80% <33.33%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@flescio flescio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alfogrillo alfogrillo merged commit 45835cc into develop Feb 6, 2023
@alfogrillo alfogrillo deleted the alfogrillo/pollhistory_design_change branch February 6, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants