Do not reset device keys if migrating to CryptoSDK #7369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/crypto_fixes
branch
from
8b0ba9f
to
ef4044f
Compare
Anderas
requested review from
a team and
stefanceriu
and removed request for
a team
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 12.08% // Head: 12.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7369 +/- ##
===========================================
+ Coverage 12.08% 12.11% +0.03%
===========================================
Files 1638 1638
Lines 161939 162001 +62
Branches 66480 66527 +47
===========================================
+ Hits 19568 19627 +59
- Misses 141725 141728 +3
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy crypto does some kind of patchwork and resets device keys on session reload. In practice this means that we reset all tracked users, and when migrating to CryptoSDK we do not have any of the tracked users information.
To solve this we simply avoid resetting device keys when the
cryptoSDKfeature flag has just been enabled (note that the next time we are resetting session, crypto will no longer be theMXLegacyCryptotype)