Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location centring user's sharing location #7398

Merged
merged 8 commits into from
Mar 2, 2023

Conversation

flescio
Copy link
Contributor

@flescio flescio commented Mar 1, 2023

Fixes bug about centring user in live location sharing

@flescio flescio requested review from alfogrillo, a team and aringenbach and removed request for a team March 1, 2023 13:56
Flavio Alescio added 2 commits March 1, 2023 16:58
Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 36.36% and no project coverage change

Comparison is base (081615f) 12.15% compared to head (560a9b5) 12.16%.

❗ Current head 560a9b5 differs from pull request most recent head cc8ecc1. Consider uploading reports for the commit cc8ecc1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7398   +/-   ##
========================================
  Coverage    12.15%   12.16%           
========================================
  Files         1643     1643           
  Lines       162265   162293   +28     
  Branches     66630    66640   +10     
========================================
+ Hits         19729    19739   +10     
- Misses      141890   141909   +19     
+ Partials       646      645    -1     
Flag Coverage Δ
uitests 55.31% <36.36%> (-0.01%) ⬇️
unittests 6.02% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ingViewer/LiveLocationSharingViewerViewModel.swift 47.87% <0.00%> (-2.13%) ⬇️
...SharingViewer/View/LiveLocationSharingViewer.swift 0.64% <0.00%> (ø)
...g/StartLocationSharing/LocationSharingModels.swift 66.66% <0.00%> (-13.34%) ⬇️
...SharingViewer/StaticLocationViewingViewModel.swift 34.92% <0.00%> (ø)
...ocationSharingViewer/View/StaticLocationView.swift 0.00% <0.00%> (ø)
...tartLocationSharing/LocationSharingViewModel.swift 9.27% <33.33%> (ø)
...nSharing/MapView/View/LocationSharingMapView.swift 56.63% <57.14%> (+2.26%) ⬆️
...haringViewer/LiveLocationSharingViewerModels.swift 13.33% <100.00%> (+6.19%) ⬆️
...tartLocationSharing/View/LocationSharingView.swift 57.51% <100.00%> (ø)
...ionSharingViewer/StaticLocationViewingModels.swift 33.33% <100.00%> (+13.33%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…LiveLocationSharingViewerViewModel.swift

Co-authored-by: Alfonso Grillo <alfogrillo@element.io>
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@flescio flescio merged commit 1b2a9c5 into develop Mar 2, 2023
@flescio flescio deleted the flescio/location_sharing_center_to_user branch March 2, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants