Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start QR scanning when camera ready #7469

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Start QR scanning when camera ready #7469

merged 1 commit into from
Apr 3, 2023

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Apr 3, 2023

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (54800f3) 12.30% compared to head (220fc3e) 12.29%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7469      +/-   ##
===========================================
- Coverage    12.30%   12.29%   -0.01%     
===========================================
  Files         1645     1645              
  Lines       163064   163147      +83     
  Branches     66943    66989      +46     
===========================================
+ Hits         20058    20066       +8     
- Misses      142357   142431      +74     
- Partials       649      650       +1     
Flag Coverage Δ
uitests 55.24% <ø> (+0.01%) ⬆️
unittests 6.19% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/QRCode/Reader/QRCodeReaderView.swift 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anderas Anderas merged commit d3b7fbb into develop Apr 3, 2023
@Anderas Anderas deleted the andy/qr_code branch April 3, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants