Fix: If a clientPermalinkBaseUrl is defined, we still have to support matrix.to links

[nimau]

Currently, if a custom permalinkBaseUrl is set, matrix.to permalinks are not rendered as pills.
This fix is intended to support both types of permalinks.

Current behaviour:

New behaviour:

Pull Request Checklist

• I read the contributing guide
• UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
• Accessibility has been taken into account.

• Pull request is based on the develop branch

• Pull request contains a changelog file in ./changelog.d
• You've made a self review of your PR
• Pull request includes screenshots or videos of UI changes
• Pull request includes a sign off

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0aef339) 12.29% compared to head (dadeef7) 12.29%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #7482   +/-   ##
========================================
  Coverage    12.29%   12.29%           
========================================
  Files         1645     1645           
  Lines       163155   163155           
  Branches     66991    66991           
========================================
+ Hits         20064    20066    +2     
+ Misses      142440   142439    -1     
+ Partials       651      650    -1     

Flag	Coverage Δ
uitests	55.24% <ø> (ø)
unittests	6.19% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
Riot/Modules/MatrixKit/Utils/MXKTools.m	23.89% <100.00%> (ø)
Riot/Modules/Pills/PillType.swift	85.10% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Anderas]

Could we add some unit tests for this change?

[nimau]

Could we add some unit tests for this change?

I'm not sure, clientPermalinkBaseUrl is a constant defined in BuildSettings. In order to test that both types of permalinks are rendered, you need to be able to override this constant.