Fix: add missing foreground color attribute #7501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimau
force-pushed
the
nimau/PSB-307-lasteventdescription-color
branch
from
853d89e
to
2197268
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #7501 +/- ##
===========================================
+ Coverage 12.31% 12.36% +0.05%
===========================================
Files 1645 1645
Lines 163418 163433 +15
Branches 67077 67090 +13
===========================================
+ Hits 20120 20204 +84
+ Misses 142644 142570 -74
- Partials 654 659 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
nimau
requested review from
a team and
pixlwave
and removed request for
Anderas and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the event formatter fails to create an attributed string for an event, a default attributed string is generated but it does not have a colour attribute, making it difficult to see in dark mode.
Current behaviour:
With this fix:
