Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MXLegacyCrypto #7508

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Deprecate MXLegacyCrypto #7508

merged 1 commit into from
Apr 19, 2023

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Apr 18, 2023

Related SDK change matrix-org/matrix-ios-sdk#1772

Deprecate the use of MXLegacyCrypto, which is no longer initialized on the SDK side. This means mostly removing conditional statements accessing now-unavailable API on legacy crypto module

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Anderas Anderas requested review from a team and aringenbach and removed request for a team April 18, 2023 11:48
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 7.40% and project coverage change: -0.02 ⚠️

Comparison is base (57d3b27) 12.36% compared to head (59dffb5) 12.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7508      +/-   ##
===========================================
- Coverage    12.36%   12.34%   -0.02%     
===========================================
  Files         1645     1643       -2     
  Lines       163432   162971     -461     
  Branches     67085    65984    -1101     
===========================================
- Hits         20201    20116      -85     
+ Misses      142572   142195     -377     
- Partials       659      660       +1     
Flag Coverage Δ
uitests 55.26% <ø> (ø)
unittests 6.19% <7.40%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Categories/MXBugReportRestClient+Riot.swift 12.94% <ø> (+0.15%) ⬆️
Riot/Modules/Analytics/Analytics.swift 9.21% <0.00%> (-3.51%) ⬇️
...iot/Modules/Analytics/SentryMonitoringClient.swift 0.00% <ø> (ø)
Riot/Modules/Application/LegacyAppDelegate.m 15.58% <0.00%> (+0.73%) ⬆️
...les/Authentication/AuthenticationCoordinator.swift 0.00% <0.00%> (ø)
...ation/Legacy/LegacyAuthenticationCoordinator.swift 8.62% <0.00%> (+0.33%) ⬆️
...s/Authentication/SessionVerificationListener.swift 0.00% <0.00%> (ø)
Riot/Modules/Call/CallViewController.m 0.00% <0.00%> (ø)
...Modules/Home/AllChats/AllChatsViewController.swift 28.85% <0.00%> (+0.03%) ⬆️
Riot/Modules/LaunchLoading/LaunchLoadingView.swift 0.00% <ø> (ø)
... and 7 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Anderas Anderas merged commit f23575e into develop Apr 19, 2023
@Anderas Anderas deleted the andy/deprecate_crypto branch April 19, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants