Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable accessibility for emojis during verification #7521

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

alfogrillo
Copy link
Contributor

This PR removes the accessibility for the emoji during the sessions verification leaving it just for the description labels under them.

Impacted screen
d

@alfogrillo alfogrillo requested review from a team, flescio and pixlwave and removed request for a team April 26, 2023 11:03
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (5cfac70) 12.21% compared to head (7a8374e) 12.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7521      +/-   ##
===========================================
- Coverage    12.21%   12.21%   -0.01%     
===========================================
  Files         1646     1646              
  Lines       163315   163319       +4     
  Branches     67037    67038       +1     
===========================================
  Hits         19944    19944              
- Misses      142729   142733       +4     
  Partials       642      642              
Flag Coverage Δ
unittests 6.06% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rify/SAS/Views/VerifyEmojiCollectionViewCell.swift 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alfogrillo alfogrillo merged commit dba34bb into develop Apr 26, 2023
@alfogrillo alfogrillo deleted the alfogrillo/fix_accessibility_on_emoji branch April 26, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants