Increase max. length of voice message recordings to 5m #7582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johennes
force-pushed
the
johannes/vm-length
branch
from
3d4e371
to
1167086
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jakewb-b
approved these changes
Jun 7, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #7582 +/- ##
===========================================
+ Coverage 12.34% 12.36% +0.02%
===========================================
Files 1648 1648
Lines 163634 163637 +3
Branches 67188 67194 +6
===========================================
+ Hits 20204 20238 +34
+ Misses 142765 142734 -31
Partials 665 665
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Highly appreciated from my side! 5 minutes may calm down users a bit while waiting for Element-X ;-) |
|
@jacotec the next release is currently scheduled for the week of June 19th. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this on an iPhone X and the experience felt acceptable. When recording a 5m voice message, it took two or three seconds for it to display in the timeline after pressing the send button. This isn't particularly great UX but struck me as acceptable given that the current limit appears to be quite limiting for parts of our user base (see the discussion in #5415). @jakewb-b curious if you'd be ok with this.