Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide rooms from room list #15745

Closed
skolmer opened this issue Nov 16, 2020 · 4 comments · Fixed by matrix-org/matrix-react-sdk#5445
Closed

Hide rooms from room list #15745

skolmer opened this issue Nov 16, 2020 · 4 comments · Fixed by matrix-org/matrix-react-sdk#5445
Assignees

Comments

@skolmer
Copy link

skolmer commented Nov 16, 2020

Is your suggestion related to a problem? Please describe.

We are creating lots of child rooms from a widget that are accessible via the widgets own UI. These rooms are cluttering up the room navigation. We want to be able to hide rooms from the navigation.

Describe the solution you'd like

Allow to set some metadata on room creation that allows us to hide a room from the navigation

@t3chguy
Copy link
Member

t3chguy commented Nov 16, 2020

This should probably be a matrix-doc issue for the spec to recognise such a flag otherwise it'll be visible in some clients and not in others.
The way this interplays with push_rules must also be considered as if a server says notification count 1 but that is from such a hidden room then a client will forever be stuck with a [1] count.

@turt2live
Copy link
Member

This is likely to be more possible with the communities (spaces) rewrite - blocking this behind that.

@turt2live turt2live added X-Blocked P1 A-Spaces Spaces, groups, communities labels Nov 23, 2020
@turt2live
Copy link
Member

I think there's actually a way to not have this blocked - taking it on.

@turt2live turt2live self-assigned this Nov 26, 2020
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 26, 2020
Fixes element-hq/element-web#15745

This was surprisingly easy given the number of errors I remember last time, but here it is. This also includes an over-engineered VisibilityProvider with the intention that it'll get used in the future for things like Spaces and other X as Rooms stuff.
@turt2live
Copy link
Member

well, that was surprisingly easy :s matrix-org/matrix-react-sdk#5445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants