Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a warning on e2ee rooms if you try to make them public and world-joinable. #16525

Closed
ara4n opened this issue Feb 24, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#5698
Closed

add a warning on e2ee rooms if you try to make them public and world-joinable. #16525

ara4n opened this issue Feb 24, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#5698
Assignees
@SimonBrandner
Labels
A-E2EE P1 T-Enhancement

Comments

@ara4n
Copy link
Member

ara4n commented Feb 24, 2021

No description provided.

@ara4n
Copy link
Member Author

ara4n commented Feb 24, 2021

Thinking further, I think the best bet would be an alert confirmation if you try to turn an E2EE room to be world-joinable, that says "Warning: making end-to-end encrypted rooms public renders the encryption pointless, wastes processing power, and can cause performance problems. Please consider creating a separate unencrypted public room." or similar.

@ara4n ara4n added the P1 label Feb 24, 2021
@ara4n ara4n changed the title add a warning on e2ee that you shouldn't use it for rooms which are effectively public add a warning on e2ee rooms if you try to make them public and world-joinable. Feb 24, 2021
@SimonBrandner SimonBrandner self-assigned this Feb 25, 2021
@SimonBrandner SimonBrandner mentioned this issue Feb 27, 2021
Merged
@jryans jryans added S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement and removed Z-UI/UX S-Minor Impairs non-critical functionality or suitable workarounds exist labels Mar 8, 2021
@SimonBrandner SimonBrandner mentioned this issue Apr 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
A-E2EE P1 T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a warning on E2EE rooms if you try to make them public SimonBrandner/matrix-react-sdk
3 participants
@jryans @ara4n @SimonBrandner