Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a cypress test with percy snapshot for ReplyChain #24684

Closed
luixxiul opened this issue Feb 27, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#10294
Closed

Create a cypress test with percy snapshot for ReplyChain #24684

luixxiul opened this issue Feb 27, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#10294

Comments

@luixxiul
Copy link

luixxiul commented Feb 27, 2023

Your use case

What would you like to do?

There should be a cypress test for ReplyChain to make a percy test for changes proposed by a PR like matrix-org/matrix-react-sdk#8972

Why would you like to do it?

Because it really is easy to cause a regression due to the nature of _components.pcss, which simply imports styles alphabetically without considering the semantic order in which styles should cascade and be inherited. Therefore, generally speaking, even moving a style block from one *.pcss file to another may cause a regression like this, unless you recognize the cascading order perfectly clear, which is hard for not only those who are not familiar with the style structure but also a team member/reviewer.

How would you like to achieve it?

Either by creating a cypress test for ReplyChain to let a percy test or an alternative tool check for you, whether or not the current codebase works as expected or by refactoring _components.pcss to have it respect the cascading order in order to improve the codebase and reduce dependency on an external tool like percy or by creating UI based on a brand new style codebase.

Have you considered any alternatives?

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants