Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DecoratedRoomAvatar work without room prop #25902

Closed
Tracked by #25883
germain-gg opened this issue Aug 2, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11355
Closed
Tracked by #25883

Make DecoratedRoomAvatar work without room prop #25902

germain-gg opened this issue Aug 2, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11355
Assignees
@germain-gg
Labels
T-Task Tasks for the team like planning Z-Compound

Comments

@germain-gg
Copy link
Contributor

As per matrix-org/matrix-react-sdk#11352 (comment)

This currently does not work as the room is required and the entire component runs under that assumption.

We need that component to fallback to the out of band data if the room does not exist.
@germain-gg germain-gg added the T-Task Tasks for the team like planning label Aug 2, 2023
@germain-gg germain-gg self-assigned this Aug 2, 2023
This was referenced Aug 2, 2023
Closed
Merged
Merged
@germain-gg
Copy link
Contributor Author

In the end, the answer is not to do what this task says but rather making the room prop mandatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
T-Task Tasks for the team like planning Z-Compound
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make room model mandatory on the RoomHeader matrix-org/matrix-react-sdk
2 participants
@germain-gg @daniellekirkwood