Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Room Chat Header Button Removed #26181

Closed
Tracked by #25883
Anthial opened this issue Sep 17, 2023 · 6 comments · Fixed by matrix-org/matrix-react-sdk#11911
Closed
Tracked by #25883

Video Room Chat Header Button Removed #26181

Anthial opened this issue Sep 17, 2023 · 6 comments · Fixed by matrix-org/matrix-react-sdk#11911
Assignees
@kerryarchibald
Labels
A-Room-View A-Video-Rooms Persistent group calls A-Widgets O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Labs Z-Maximised-Widgets

Comments

@Anthial
Copy link

Anthial commented Sep 17, 2023

Steps to reproduce

  1. Create a Video Room.
  2. Click said Video Room.
  3. If the Chat is available, close it down.
  4. There is now no way to reopen the chat

Outcome

What did you expect?

There used to be a header button to open the chat.

What happened instead?

The header button is gone, there seems to be no way to reopen the chat once it is closed. There is still a search button, but it is non-functional.

Operating system

Windows

Application version

Element Nightly version: 0.0.1-nightly.2023091701 Olm version: 3.2.14

How did you install the app?

https://element.io/download#nightly

Homeserver

Synapse v1.89.0

Will you send logs?

Yes
@andybalaam
Copy link
Member

I can reproduce this.

@andybalaam andybalaam added X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-Labs Z-Compound labels Sep 18, 2023
@andybalaam
Copy link
Member

This does not block release since video rooms are a labs feature, but this needs fixing before we unlabs the room header.

@t3chguy t3chguy mentioned this issue Sep 18, 2023
Closed
@DoM1niC
Copy link

DoM1niC commented Sep 19, 2023

image
small remark start Voice / Video Call have to hidden in VoIP Rooms

@germain-gg germain-gg self-assigned this Sep 21, 2023
@github-actions github-actions bot removed the Z-Labs label Oct 12, 2023
@manancodes
Copy link

I'm working on adding this in the new header.

@manancodes manancodes mentioned this issue Oct 15, 2023
Closed
3 tasks
This was referenced Nov 9, 2023
Closed
Closed
@kerryarchibald
Copy link
Contributor

Design for video room header:
Screenshot 2023-11-15 at 10 44 05
https://www.figma.com/file/rTaQE2nIUSLav4Tg3nozq7/Compound-Web-Components?type=design&node-id=1073-201&mode=design&t=tn0WOIXvbzFrmey6-0

@kerryarchibald kerryarchibald mentioned this issue Nov 21, 2023
Merged
3 tasks
@kerryarchibald kerryarchibald self-assigned this Nov 21, 2023
@kerryarchibald kerryarchibald mentioned this issue Nov 21, 2023
Merged
3 tasks
@manancodes
Copy link

I was working on this issue in matrix-org/matrix-react-sdk#11752 but could not write the tests because of the festive season here in India for a few days. And now I see another PR created to fix this. Should I close my PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kerryarchibald kerryarchibald

Labels
A-Room-View A-Video-Rooms Persistent group calls A-Widgets O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Labs Z-Maximised-Widgets
Projects
None yet
Milestone
No milestone
7 participants
@andybalaam @germain-gg @DoM1niC @kerryarchibald @Anthial @robintown @manancodes