Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid flashes of glitching when viewing rooms #1323

Closed
nadonomy opened this issue Sep 13, 2023 · 0 comments · Fixed by #1405
Closed

Avoid flashes of glitching when viewing rooms #1323

nadonomy opened this issue Sep 13, 2023 · 0 comments · Fixed by #1405
Assignees
@bmarty @nadonomy
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@nadonomy
Copy link

nadonomy commented Sep 13, 2023 •
edited
Loading

When viewing a room, it's common to momentarily get flashes of different loading states or backgrounds, similar to a flash of unstyled content on the web.

We should avoid this, smoothing over visual glitches by:

  • If showing a spinner in the timeline, only show it after several hundred ms (5-800?) of loading, to avoid it just flashing momentarily
  • Alpha'ing in & out the spinners over 100ms or so
  • Alpha'ing in the timeline content over 100ms or so, instead of it instantly flashing in
@nadonomy nadonomy added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Sep 13, 2023
@nadonomy nadonomy self-assigned this Sep 14, 2023
@nadonomy nadonomy changed the title Avoid FOUC glitching when viewing rooms Avoid flashes of glitching when viewing rooms Sep 14, 2023
@jonnyandrew jonnyandrew added S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Timeline labels Sep 19, 2023
@bmarty bmarty self-assigned this Sep 21, 2023
bmarty added a commit that referenced this issue Sep 21, 2023
@bmarty
Add animation on the timeline content, to avoid glitch (#1323)
03eacdc
@bmarty bmarty mentioned this issue Sep 21, 2023
Merged
14 tasks
bmarty added a commit that referenced this issue Sep 21, 2023
@bmarty
Merge pull request #1405 from vector-im/feature/bma/timelineGlitch
8fc7a79 
Add animation on the timeline content, to avoid glitch (#1323)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

@nadonomy nadonomy

Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add animation on the timeline content, to avoid glitch (#1323) element-hq/element-x-android
3 participants
@bmarty @nadonomy @jonnyandrew