Move Map Libre API key to Xcode Cloud #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 0bd018d |
alfogrillo
force-pushed
the
alfogrillo/inject_maplibre_key
branch
5 times, most recently
from
50cbc71
to
6bda3e8
Compare
alfogrillo
changed the title
alfogrillo
requested review from
stefanceriu and
pixlwave
and removed request for
a team and
stefanceriu
alfogrillo
force-pushed
the
alfogrillo/inject_maplibre_key
branch
2 times, most recently
from
3a1d7d5
to
8c88395
Compare
pixlwave
approved these changes
Jul 13, 2023
UnitTests/Sources/NotificationManager/NotificationManagerTests.swift
Outdated
Show resolved
Hide resolved
pixlwave
approved these changes
Jul 13, 2023
alfogrillo
force-pushed
the
alfogrillo/inject_maplibre_key
branch
from
2630a82
to
73c8ad8
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1313 +/- ##
===========================================
+ Coverage 44.16% 44.17% +0.01%
===========================================
Files 395 395
Lines 26023 26026 +3
Branches 13258 13259 +1
===========================================
+ Hits 11494 11498 +4
Misses 14236 14236
+ Partials 293 292 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alfogrillo
force-pushed
the
alfogrillo/inject_maplibre_key
branch
from
32ee27f
to
0bd018d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the map libre api key into Xcode Cloud (as a secret).
Xcode Cloud workflows will inject the key back into the app when creating a new production/nightly build.
It also adds a step in the
setup-projectaction to configure the api key locally.