Build electron app from pre-built tarball #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still won't work, still a WIP
Just always build for the native platform
jryans
approved these changes
Dec 9, 2019
jryans
reviewed
Dec 9, 2019
We use the default now
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
jryans
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Anything that didn't need any changes made to it I have already imported into the project and put on the master branch, so this is just code that has actually changed.
Also add some linting because why not. The linting fails atm: currently trying to avoid diverging the code too much from what's in the riot-web repo.
Requires element-hq/element-web#11631
Fixes element-hq/element-web#11607