Native module builds: matrix-seshat for mac & win #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May not be exhastive, but useful on Windows where you need to remember to install stuff.
Merged
poljar
reviewed
Feb 17, 2020
poljar
reviewed
Feb 17, 2020
poljar
reviewed
Feb 17, 2020
poljar
reviewed
Feb 17, 2020
More fixes under, 'typing is hard' Co-Authored-By: poljar <poljar@termina.org.uk>
turt2live
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
I haven't tried to verify every single flag, version, or whether the program flow is decent. There's no code that appears to steal people's keys though, so that's good.
Presumably it also works and actually builds the thing. A bit unfortunate that we've invented a build tool, but it looks like we need it.
|
Thanks. And yep, the functionality here probably belongs somewhere between electron-rebuild which neon are trying to add support for but haven't yet, and either the package itself or the app. Either way the code needs to be somewhere, and if it has to be somewhere I guess I'd rather it be in a modular-ish tool than a giant script of doom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on Linux now, but submitting this as a PR as it stands in the interest of smaller PR chunks as it's already getting largeish.
Note the native module build scripts come in the form of a maybe-could-be-generic-ish tool called
hak, which I've written about in its own README.md.