Fix electron context menu copy/save-as #96
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#13845
We had a bunch of issues with the copy/save context menus we presented. The above being due to the
showSaveDialog
going async, instead of using the newshowSaveDialogSync
option I opted to switch it and thefs
calls to async/await.I tried to (ab)use the clipboard for save-as on blob URLs and whilst it did work fundamentally, there was no way to accurately get the timing right. There is no way of knowing when
copyImageAt
is done and the clipboard is ready for us to read the image from.