Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build:jitsi scripts crash caused by a missing folder #13122

Merged
merged 1 commit into from
Apr 10, 2020
Merged

fix build:jitsi scripts crash caused by a missing folder #13122

merged 1 commit into from
Apr 10, 2020

Conversation

dannycolin
Copy link
Contributor

On a freshly install of the development environment, the build:jitsi try to create a file in ./webapp with the cURL command. However, ./webapp folder doesn't exist and the build script crash.

$ curl -s https://jitsi.riot.im/libs/external_api.min.js > ./webapp/jitsi_external_api.min.js
2020-04-10 13:41:05.148 [res] /bin/sh: ./webapp/jitsi_external_api.min.js: No such file or direc
error Command failed with exit code 1.

This patch makes sure the appropriate folder is created if it doesn't already exist

@dannycolin
fix build:jitsi scripts crash caused by a missing folder
c128e75 
On a freshly install of the developer environment, the build:jitsi try
to create a file in ./webapp with the cURL command. However, ./webapp
folder doesn't exist and the build script crash. This patch makes sure
the appropriate folder is created if it doesn't already exist

Signed-off-by: Danny Colin <contact@dannycolin.com>
@t3chguy t3chguy requested a review from a team April 10, 2020 19:54
turt2live
turt2live approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we need a whole script for this as we could just use mkdir -p ./webapp, but this is fine. Thanks!

@turt2live turt2live merged commit 3021051 into element-hq:develop Apr 10, 2020
@turt2live turt2live added the Z-Community-PR Issue is solved by a community member's PR label Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannycolin @turt2live