Replace favico.js dependency with simplified variant grown from it #13649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
dbkr
approved these changes
May 14, 2020
t3chguy
commented
May 14, 2020
There was a problem hiding this comment.
Just realised I forgot to wire up the badge-time bgColor switch: https://github.com/vector-im/riot-web/pull/13649/files#diff-94c050e21d5144980560fe9e860895b1R89
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
dbkr
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4709
Fixes #11121
Fixes #13035
It behaves identically but with much less cruft and much better responsiveness.
