Add notranslate class to matrixchat to prevent translation by Google Translate #13669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Translate Google Translate manipulates the DOM which is fundamentally incomaptible with React and causes exceptions to be thrown when React tries to manipulate the DOM based on its VDOM and the DOM methods throw exceptions because the DOM structure is not what React thinks it is. Riot has an i18n system, although it doesn't cover all strings and all languages. Fixes #13557
bwindels
approved these changes
May 14, 2020
|
This has unfortunately introduced a serious accessibility issue; at least one user is using the Google Translate extension to help them follow conversations in a language that they do not speak natively. I suspect there may be more users doing the same. That possibility is broken by this change. |
|
@joepie91 it's best to open new issues instead of commenting on old PRs as we tend to dismiss notifications on closed things. |
|
Google Translate breaks React in many many ways; https://bugs.chromium.org/p/chromium/issues/detail?id=872770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Translate manipulates the DOM which is fundamentally incomaptible with
React and causes exceptions to be thrown when React tries to manipulate the DOM
based on its VDOM and the DOM methods throw exceptions because the DOM structure
is not what React thinks it is.
Riot has an i18n system, although it doesn't cover all strings and all languages.
Fixes #13557
Alternative to: #13658