Update README now the js-sdk has a transpile step #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested changes
Jan 11, 2017
| @@ -58,8 +58,11 @@ to build. | |||
| 1. Install the prerequisites: `npm install` | |||
| 1. If you are using the `develop` branch of vector-web, you will probably need | |||
| to rebuild one of the dependencies, due to | |||
| running `npm start` in the directory, to start a development builder which | ||
| will watch for changes to the files and rebuild automatically. | ||
| When you make changes to `matrix-react-sdk` or `matrix-js-sdk`, you will need | ||
| to run `npm run build` in the relevant directory. You can do this automatically |
There was a problem hiding this comment.
Annoyingly, I think it is npm run compile for the js-sdk.
There was a problem hiding this comment.
It would obviously be preferable to fix this by bringing the js-sdk into line.
There was a problem hiding this comment.
Fixed in matrix-org/matrix-js-sdk#320 by having npm run build do the things you need (and more!)
richvdh
reviewed
Jan 11, 2017
| https://github.com/npm/npm/issues/3055: `(cd node_modules/matrix-react-sdk | ||
| && npm install)` | ||
| https://github.com/npm/npm/issues/3055: | ||
| ``` |
There was a problem hiding this comment.
|
ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.