New guest access #4039
Merged
New guest access #4039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSS for new SetMxIdDialog
This will tell the user that they need to set a password to return to their account.
Implement PasswordNagBar
CSS for mxIdDialog redesign
Conflicts: src/component-index.js
…-user Add welcomeUserId to sample config
Until matrix-org/matrix-react-sdk#881, ChangePassword will not know about the cached password (so it won't hide "Current Password" yet). There's also a bit of work left - informing the SessionStore that the password has changed (marked with a TODO)
…-set-mx-id Replace NeedToRegister with SetMxId dialog
…-dialog Implement dialog to set password
…us-new-password autoFocus new password input in SetPasswordDialog
…-dialog-fuzzy Add warm-fuzzy for successful password entry
Tom welcome page
… new-guest-access
Possble thanks to matrix-org/matrix-react-sdk#1006
Also remove newline in translation string.
Add missing translation for room directory
Update home.html
i18n for SetPasswordDialog
This time the test wasn't being flaky, but it does inspect a lot of the internal of RoomView, which has had some modifications recently. I've updated the test to reflect this and it passes locally. Also, fix a bug in HomePage with an undeclared "error" which should be "err". Let's see what Travis thinks of this!
Fix tests for new-guest-access
As we now use it from vector, so we shouldn't rely on it being pulled in via react-sdk
The q.delay is needed to make sure (or at least reasonably sure...) that the login component has appeared by that point. The done handler needs to be the error callback too otherwise failures result in timeouts rather than the actual failure.
To work around the fact that we now do more trips around the event loop to update view state (because of going vis the store). Also add comment saying how horrible this is.
Fix Tests in ILAG
As we are not always at the root of the web server.
Remove '/' from homepage URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a PR for new guest access mainly to visualise how merge conflicty this is...
twinned with matrix-org/matrix-react-sdk#937