Add border on hover for code blocks #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Hunt <oliver@hunt.bz>
ara4n
reviewed
Jun 9, 2017
| @@ -345,6 +345,11 @@ limitations under the License. | |||
| } | |||
| .mx_EventTile_body pre { | |||
| position: relative; | |||
| border: 1px solid #f8f8f8; | |||
There was a problem hiding this comment.
hm, surely this should be a $ variable so that it themes correctly?
|
one comment, otherwise lgtm. Also, you might want to just consider |
Signed-off-by: Oliver Hunt <oliver@hunt.bz>
|
thanks |
dbkr
pushed a commit
that referenced
this pull request
Jun 19, 2017
Add border on hover for code blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The border for non hovered codeblocks is the same colour as the background, and there so the content doesn't move when the border is added.