fix Quote not closing contextual menu #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also use `this.closeMenu();` over the explicit direct call as the wrapper exists and is a little clearer
lukebarnard1
approved these changes
Jun 27, 2017
t3chguy
force-pushed
the
t3chguy/patch-3
branch
2 times, most recently
from
a18cc1c to
f36c1ca
Compare
|
I'm going to try the arbitrary thing of cherry-picking this onto a fresh branch to see whether that cheers Travis up |
|
I've restarted the builds 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also use
this.closeMenu();over the explicit direct call as the wrapper exists and is a little clearerfixes
