un-i18n Modal Analytics #4688
Merged
un-i18n Modal Analytics #4688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
lukebarnard1
suggested changes
Aug 10, 2017
| title: _t('Room not found'), | ||
| description: _t('Couldn\'t find a matching Matrix room'), | ||
| }); | ||
| } | ||
| }, (e) => { | ||
| const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); | ||
| Modal.createDialog(ErrorDialog, { | ||
| Modal.createTrackedDialog('Fetching third party location failed', e.toString(), ErrorDialog, { |
| @@ -99,7 +99,7 @@ module.exports = React.createClass({ | |||
| const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); | |||
| // display error message stating you couldn't delete this. | |||
| const code = e.errcode || e.statusCode; | |||
| Modal.createDialog(ErrorDialog, { | |||
| Modal.createTrackedDialog('You cannot delete this message', e.toString(), ErrorDialog, { | |||
| @@ -76,7 +76,7 @@ module.exports = React.createClass({ | |||
| var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); | |||
| // display error message stating you couldn't delete this. | |||
| var code = e.errcode || e.statusCode; | |||
| Modal.createDialog(ErrorDialog, { | |||
| Modal.createTrackedDialog('You cannot delete this image.', e.toString(), ErrorDialog, { | |||
| @@ -131,7 +131,7 @@ module.exports = React.createClass({ | |||
| this._refreshFromServer(); | |||
| }, (error) => { | |||
| var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); | |||
| Modal.createDialog(ErrorDialog, { | |||
| Modal.createTrackedDialog('Error saving email notification preferences', error.toString(), ErrorDialog, { | |||
| @@ -241,7 +241,7 @@ module.exports = React.createClass({ | |||
| }, function(error) { | |||
| var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); | |||
| console.error("Failed to change settings: " + error); | |||
| Modal.createDialog(ErrorDialog, { | |||
| Modal.createTrackedDialog('Failed to change settings', error.toString(), ErrorDialog, { | |||
| @@ -311,7 +311,7 @@ module.exports = React.createClass({ | |||
| }, function(error) { | |||
| var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); | |||
| console.error("Can't update user notification settings: " + error); | |||
| Modal.createDialog(ErrorDialog, { | |||
| Modal.createTrackedDialog('Can\'t update user notifcation settings', error.toString(), ErrorDialog, { | |||
| @@ -353,7 +353,7 @@ module.exports = React.createClass({ | |||
| var onError = function(error) { | |||
| var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); | |||
| console.error("Failed to update keywords: " + error); | |||
| Modal.createDialog(ErrorDialog, { | |||
| Modal.createTrackedDialog('Failed to update keywords', error.toString(), ErrorDialog, { | |||
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
lukebarnard1
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com
paired with matrix-org/matrix-react-sdk#1255