Add Jitsi screensharing support in electron app #4967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
requested changes
Sep 4, 2017
| @@ -21,7 +21,7 @@ import VectorBasePlatform, {updateCheckStatusEnum} from './VectorBasePlatform'; | |||
| import dis from 'matrix-react-sdk/lib/dispatcher'; | |||
| import { _t } from 'matrix-react-sdk/lib/languageHandler'; | |||
| import Promise from 'bluebird'; | |||
| import {remote, ipcRenderer} from 'electron'; | |||
| import electron, {remote, ipcRenderer} from 'electron'; | |||
There was a problem hiding this comment.
why not just import desktopCapturer into the destructured imports instead of importing the whole of electron
you're already "slighltly-modifying" the copied code
dbkr
approved these changes
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on: matrix-org/matrix-react-sdk#1355
I don't like that I had to copy code for this. It is Apache v2.0 licensed code with no specific copyright header. However, the full https://github.com/jitsi/jitsi-meet-electron-utils is a native electron module that would significantly complicate its integration when we just want to use this small amount of JS code. Comments/help welcome on this.