Remove key prop pass-thru on HeaderButton
#5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is redundant and throws a warning
dbkr
approved these changes
Sep 28, 2017
t3chguy
requested changes
Sep 28, 2017
| key={this.props.key} | ||
| onClick={ this.onClick } | ||
| > | ||
| return <AccessibleButton className="mx_RightPanel_headerButton" onClick={ this.onClick } > |
There was a problem hiding this comment.
plus I feel like you at one point told me props get no space padding within {}
There was a problem hiding this comment.
this is true, I've added an eslint rule for this - matrix-org/matrix-react-sdk#1436
t3chguy
reviewed
Sep 28, 2017
| key={this.props.key} | ||
| onClick={ this.onClick } | ||
| > | ||
| return <AccessibleButton className="mx_RightPanel_headerButton" onClick={this.onClick} > |
There was a problem hiding this comment.
/me thought should be onClick={this.onClick}> similar to the <div below not padding out its closing >
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is redundant and throws a warning