Swap RoomList to react-beautiful-dnd #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes themeing See matrix-org/matrix-react-sdk#1711
lukebarnard1
force-pushed
the
luke/roomlist-beautiful-dnd
branch
from
5fd7d71 to
3481283
Compare
ara4n
reviewed
Jan 18, 2018
| // lastTargetRoom: null, | ||
| // lastYOffset: null, | ||
| // lastYDelta: null, | ||
| getStyle(isDragging) { |
There was a problem hiding this comment.
can we apply this style via a CSS class rather than hardcoding it in here, in order to make it skinnable/themable?
There was a problem hiding this comment.
I don't see why not, actually. I was persuaded by the library examples that all did it this way but there's no obvious advantage.
|
lgtm other than the theming point (and failing tests). very exciting!!!! |
Theres no benefit to using inline styles
|
The failing tests are travis being travis and not starting chrome: travis-ci/travis-ci#8836. I shall add |
|
lgtm |
This was referenced May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes themeing
See matrix-org/matrix-react-sdk#1711