Add transparent CSS class for RoomTile #6281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
reviewed
Mar 6, 2018
| @@ -104,6 +104,8 @@ $roomtile-name-color: rgba(69, 69, 69, 0.8); | |||
| $roomtile-selected-bg-color: rgba(255, 255, 255, 0.8); | |||
| $roomtile-focused-bg-color: rgba(255, 255, 255, 0.9); | |||
|
|
|||
| $roomtile-transparent-focused-color: rgba(0, 0, 0, 0.1); | |||
There was a problem hiding this comment.
why are we darkening it for focus? the rest of the UI brightens things for focus...
There was a problem hiding this comment.
In the light theme it has a white background to begin with, so we can't go any brighter. Would you propose something else?
There was a problem hiding this comment.
well, we could lighten the foreground even if the background is already saturated. i'll merge it as is though and see how it looks and tweak as needed then.
|
lgtm other than cosmetic query |
|
Fixes #6210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.