Remove node 8.x from the build matrix #9159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't support Node 8 anymore. Also the build is broken.
jryans
approved these changes
Mar 13, 2019
.travis.yml
Outdated
| @@ -15,8 +15,10 @@ node_js: | |||
| # Current status of node versions: https://github.com/nodejs/LTS/ | |||
| # We don't work with node 6 because it doesn't support package-lock | |||
| # files which we need to avoid the broken version of base-x | |||
There was a problem hiding this comment.
Maybe remove the historical explanation above? Our supported set is now effectively "LTS or newer", so I don't think we need to say much more to explain it. (Whatever seems best to you though!)
There was a problem hiding this comment.
I have to admit: I didn't actually read any of this. Will remove the explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't support Node 8 anymore. Also the build is broken.