Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The vector test command does not require tests or warn that no tests were found #1756

Closed
binarylogic opened this issue Feb 8, 2020 · 4 comments
Assignees
Labels
domain: cli Anything related to Vector's CLI domain: tests Anything related to Vector's internal tests type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@binarylogic
Copy link
Contributor

➜ vector test
Running /etc/vector/vector.toml tests

We should error or note that there aren't any tests.

@binarylogic binarylogic added type: enhancement A value-adding code change that enhances its existing functionality. domain: tests Anything related to Vector's internal tests domain: cli Anything related to Vector's CLI labels Feb 8, 2020
@Jeffail
Copy link
Contributor

Jeffail commented Feb 8, 2020

I've already added a warning 5addaea to state that no tests were run. But I'm wondering if it's worth extending the message to something like No tests were found, for guidance check out https://vector.dev/docs/setup/guides/unit-testing/. More verbose == more annoying in CI logs when the user already knows (like maybe they're running vector test ./somewhere/*.toml and know there are some files without tests), but it's also nice to send users directly to where they can learn more.

@binarylogic
Copy link
Contributor Author

Yeah, I don't think that's necessary just yet. I have #978 open which could be used to solve that. It also wouldn't be bad to include that in the command's description. The URL is so long though :/ .

@Hoverbear
Copy link
Contributor

We can use Netlify redirects to create some shortlinks ala vector.dev/@/testing or whatnot.

@binarylogic
Copy link
Contributor Author

Yep. I'm closing this for now since there is proper messaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: cli Anything related to Vector's CLI domain: tests Anything related to Vector's internal tests type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

No branches or pull requests

3 participants