Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The interval option in demo_logs is broken since vector 0.28 #18140

Closed
fdhmcts opened this issue Aug 2, 2023 · 1 comment
Closed

The interval option in demo_logs is broken since vector 0.28 #18140

fdhmcts opened this issue Aug 2, 2023 · 1 comment
Labels
type: bug A code related bug.

Comments

@fdhmcts
Copy link

fdhmcts commented Aug 2, 2023

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

The interval option in demo_logs is broken since vector 0.28, and it is still broken in vector 0.31. It was still working in vector 0.27. The "interval" option in the "demo_logs" source seems to be rounded up or down to the nearest integer. We should be able to use decimal values such as "0.01" to control how often a new message is created. Now, it behaves as if we put an integer number. For example if we use "interval = 0.49" it will be rounded down to 0 and produce as many messages as possible. If we use "interval = 0.51" it will behave as if we had used "interval = 1" so it will wait one second.

Configuration

[sources.my_source_id]
type = "demo_logs"
format = "json"
interval = 0.1

Version

0.31

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

@fdhmcts fdhmcts added the type: bug A code related bug. label Aug 2, 2023
@jszwedko
Copy link
Member

jszwedko commented Aug 2, 2023

Hi @fdhmcts !

This bug was actually discovered and fixed over here: #17917. It will be included in 0.32.0. Thanks for flagging! I didn't realize it was a regression; I was assuming the bug had always existed. I'll close this out, but let me know if you have any additional thoughts. To verify the fix works for you, you can try one of the Vector nightly builds (https://vector.dev/download/ -- switch to Nightly or the nightly Docker image builds: https://hub.docker.com/repository/docker/timberio/vector/tags?page=1&ordering=last_updated&name=nightly).

@jszwedko jszwedko closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A code related bug.
Projects
None yet
Development

No branches or pull requests

2 participants